Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to history tuple array #284

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Add labels to history tuple array #284

merged 4 commits into from
Feb 16, 2025
+90 −32

Conversation

sidepelican
Copy link
Collaborator

Issue: #283

Add labels to the history property of mock function arguments.
These labels enhance the readability of the test code.

Since access by index remains possible even with the addition of labels, I believe this change does not break backward compatibility.

let t = (a: 0, b: 1)
t.0 // 0
t.a // 0

fummicc1
fummicc1 approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sidepelican sidepelican merged commit b2cf6d6 into uber:master Feb 16, 2025
3 checks passed
@sidepelican sidepelican deleted the history_label branch February 16, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fummicc1 fummicc1 fummicc1 approved these changes

@uhooi uhooi Awaiting requested review from uhooi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidepelican @fummicc1